You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/04/04 08:11:00 UTC

[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

    [ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708304#comment-17708304 ] 

ASF subversion and git services commented on OFBIZ-12723:
---------------------------------------------------------

Commit 5267532fdeeba262cd2f1d5f7e40a98bcbefcaa5 in ofbiz-framework's branch refs/heads/ofbiz-12723 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5267532fde ]

Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

Fields were used to migrate QOH and ATP inventory values to
InventoryItemDetails entities following data model changes prior to June
2006 are are no longer needed. Similarly, services which performed the
migration have also been removed.


> Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-12723
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12723
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: datamodel, product
>    Affects Versions: Upcoming Branch
>            Reporter: Daniel Watford
>            Assignee: Daniel Watford
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>
> Remove fields oldQuantityOnHand and oldAvailableToPromise from the InventoryItem entity, associated view-entities, forms and services.
> OFBiz currently has a maintenance service, updateOldInventoryToDetailAll, which finds any InventoryItems where oldQuantityOnHand or oldAvailableToPromise are populated and creates corresponding InventoryItemDetail entities. The oldQuantityOnHand and oldAvailableToPromise fields are then cleared.
> Based on source code repository logs, were already in the data model when OFBiz was imported into subversion 1st July 2006.
> Given the column names for the fields are hard-coded in the data model as QUANTITY_ON_HAND and AVAILABLE_TO_PROMISE, I assume these entity fields, along with the updateOldInventoryToDetailAll service, were implemented as a method of upgrading the data model and are no longer used.
> Since these fields are no longer used, lets remove them and their related code, (slightly) reducing the size of ofbiz' sources that need to be maintained.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)