You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/01 23:01:35 UTC

[GitHub] [spark] itholic edited a comment on pull request #35687: [SPARK-38353][PYTHON] Instrument __enter__ and __exit__ magic methods for Pandas module

itholic edited a comment on pull request #35687:
URL: https://github.com/apache/spark/pull/35687#issuecomment-1055944686


   Could you elaborate more detail why do we need `__enter__` and `__exit__` to the usage log for pandas API on Spark ??
   
   It would be great if we have an example to show the reason why adding `__enter__` and `__exit__` improve the instrumentation accuracy ?
   
   And could you also fill the description for JIRA ticket (https://issues.apache.org/jira/browse/SPARK-38353) ??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org