[jira] Updated: (THRIFT-339) THRIFT-242 is incompatible with arguments with empty key fields

["Alexander Shigin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Shigin updated THRIFT-339:
------------------------------------

    Attachment: default+neg-field-2.diff

sync patch with head

> THRIFT-242 is incompatible with arguments with empty key fields
> ---------------------------------------------------------------
>
>                 Key: THRIFT-339
>                 URL: https://issues.apache.org/jira/browse/THRIFT-339
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Python)
>    Affects Versions: 0.1
>            Reporter: Jonathan Ellis
>             Fix For: 0.2
>
>         Attachments: default+neg-field-2.diff, default+neg-field.diff, thrift-339-2.patch, thrift-339-3.patch, thrift-339-4.patch, thrift-339-5.patch, thrift-339-6.patch, thrift-339.patch, thrift-python-defaults-v2.patch, thrift-python-defaults.patch
>
>
> Esteve's last change to how default values are stored broke stuff.  Here is a quick example:
> {{
> service Test
> {
>   bool  get_slice(i32 start = -1),
> }
> }}
> generates
> {{
> class get_slice_args:
>   thrift_spec = None
>   def __init__(self, start=thrift_spec[-1][4],):
>     self.start = start
> }}
> which is obviously invalid.
> I'm not sure how thrift_spec is supposed to be populated here so I'm unsure how to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.