[GitHub] [cassandra] maedhroz commented on a change in pull request #1083: CASSANDRA-16737(3.11): Read only the required SSTables for single partition queries

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1083:
URL: https://github.com/apache/cassandra/pull/1083#discussion_r660999048



##########
File path: src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java
##########
@@ -692,7 +692,7 @@ private UnfilteredRowIterator queryMemtableAndDiskInternal(ColumnFamilyStore cfs
          *      we can't guarantee an older sstable won't have some elements that weren't in the most recent sstables,
          *      and counters are intrinsically a collection of shards and so have the same problem).
          */
-        if (clusteringIndexFilter() instanceof ClusteringIndexNamesFilter && !queriesMulticellType())
+        if (clusteringIndexFilter() instanceof ClusteringIndexNamesFilter && !metadata().isCounter() && !queriesMulticellType())

Review comment:
       Counters were mentioned in the comment but not in the conditional :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org