You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2017/06/15 17:49:04 UTC
[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden
David Knupp has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7197
Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden
......................................................................
IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden
Tested by exporting a different IMPALA_LOGS_DIR path, then confirming
that it was not changed by sourcing impala-config.sh.
Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/7197/1
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has uploaded a new patch set (#2).
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
Tested by exporting a different IMPALA_LOGS_DIR path, then confirming
that it was not changed by sourcing impala-config.sh.
Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/7197/2
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7197/1//COMMIT_MSG
Commit Message:
PS1, Line 7: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden
> Nit: wording. Maybe:
Done
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
Tested by exporting a different IMPALA_LOGS_DIR path, then confirming
that it was not changed by sourcing impala-config.sh.
Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Reviewed-on: http://gerrit.cloudera.org:8080/7197
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
David Knupp: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7197/1//COMMIT_MSG
Commit Message:
PS1, Line 7: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden
Nit: wording. Maybe:
Allow IMPALA_LOGS_DIR to be overridden
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
Patch Set 3: Code-Review+2
Rebase only. Carrying +2.
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/776/
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4028813bd4f53815139225abd57845bb304ae3e4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No