You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/08/09 17:18:47 UTC

[GitHub] spark pull request #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc ...

GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/22059

    [SPARK-25036][SQL] Avoid discarding unmoored doc comment in Scala-2.12. 

    ## What changes were proposed in this pull request?
    
    This PR avoid the following compilation error using sbt in Scala-2.12.
    
    ```
    [error] [warn] /home/ishizaki/Spark/PR/scala212/spark/mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala:410: discarding unmoored doc comment
    [error] [warn]     /**
    [error] [warn] 
    [error] [warn] /home/ishizaki/Spark/PR/scala212/spark/mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala:441: discarding unmoored doc comment
    [error] [warn]     /**
    [error] [warn] 
    ...
    [error] [warn] /home/ishizaki/Spark/PR/scala212/spark/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:440: discarding unmoored doc comment
    [error] [warn]     /**
    [error] [warn] 
    ```
    
    ## How was this patch tested?
    
    Existing UTs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-25036d

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22059.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22059
    
----
commit 70ec11e5b85100b0b10257f7c0846b63af1ba494
Author: Kazuaki Ishizaki <is...@...>
Date:   2018-08-09T17:11:30Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94511/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2008/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2016/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    **[Test build #94511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94511/testReport)** for PR 22059 at commit [`70ec11e`](https://github.com/apache/spark/commit/70ec11e5b85100b0b10257f7c0846b63af1ba494).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    cc @srowen @ueshin @HyukjinKwon 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    **[Test build #94520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94520/testReport)** for PR 22059 at commit [`70ec11e`](https://github.com/apache/spark/commit/70ec11e5b85100b0b10257f7c0846b63af1ba494).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22059: [SPARK-25036][SQL] Avoid discarding unmoored doc comment...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22059
  
    **[Test build #94511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94511/testReport)** for PR 22059 at commit [`70ec11e`](https://github.com/apache/spark/commit/70ec11e5b85100b0b10257f7c0846b63af1ba494).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org