You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Chris A. Mattmann (JIRA)" <ji...@apache.org> on 2014/08/02 22:59:12 UTC

[jira] [Updated] (OODT-727) Rename actions to their prior names in CAS-Crawler

     [ https://issues.apache.org/jira/browse/OODT-727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann updated OODT-727:
-----------------------------------

    Description: 
OODT-325 and this commit http://svn.apache.org/viewvc?view=revision&revision=1294389 introduced new names to CrawlerActionBeans, such as
* Renaming UpdateWorkflowStatusToIngest to TriggerPostIngestWorkflow
* Renaming MoveMetadataToBackupDir to MoveMetadataFileToBackupDir
* Renaming MoveMetadataToFailureDir to MoveMetadataFileToFailureDir

You can see all the differences by running this command:
{noformat}
curl "http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/action-beans.xml?r1=1294389&r2=1294388&pathrev=1294389&view=patch" | grep id | cut -d\" -f2 | cut -d\+ -f2 | grep -v \ | sort<{noformat}

Which amount to:
{noformat}
CheckMetFileExists
CheckMetFileExists
DeleteDataFile
DeleteDataFile
DeleteMetadataFile
DeleteMetadataFile
DeletePushpullMetFile
DeletePushpullMetFile
IngestAncillaryFile
IngestAncillaryFile
MoveDataFileToFailureDir
MoveDataFileToFailureDir
MoveMetadataFileToBackupDir
MoveMetadataFileToFailureDir
MoveMetadataToBackupDir
MoveMetadataToFailureDir
MovePushpullMetFileToBackupDir
MovePushpullMetFileToBackupDir
MovePushpullMetFileToFailureDir
MovePushpullMetFileToFailureDir
SendNotification
SendNotification
TriggerPostIngestWorkflow
Unique
Unique
UpdateWorkflowStatusToIngest
ignoreInvalidAddresses
ignoreInvalidAddresses
{noformat}

I can find no justification for these changes and technically it broke back compatibility with folks using those action names. I am going to change the action names back to what they were called.


  was:
OODT-325 and this commit http://svn.apache.org/viewvc?view=revision&revision=1294389 introduced new names to CrawlerActionBeans, such as
* Renaming UpdateWorkflowStatusToIngest to TriggerPostIngestWorkflow

You can see all the differences by running this command:
{noformat}
curl "http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/action-beans.xml?r1=1294389&r2=1294388&pathrev=1294389&view=patch" | grep id | cut -d\" -f2 | cut -d\+ -f2 | grep -v \<{noformat}

Which amount to:

{noformat}
DeleteDataFile
DeletePushpullMetFile
DeleteMetadataFile
MovePushpullMetFileToBackupDir
MoveMetadataToBackupDir
UpdateWorkflowStatusToIngest
MoveDataFileToFailureDir
MovePushpullMetFileToFailureDir
MoveMetadataToFailureDir
Unique
CheckMetFileExists
SendNotification
ignoreInvalidAddresses
IngestAncillaryFile
{noformat}

changed to:
{noformat}
DeleteDataFile
DeleteMetadataFile
DeletePushpullMetFile
MoveDataFileToFailureDir
MoveMetadataFileToFailureDir
MovePushpullMetFileToFailureDir
MovePushpullMetFileToBackupDir
MoveMetadataFileToBackupDir
TriggerPostIngestWorkflow
Unique
IngestAncillaryFile
CheckMetFileExists
SendNotification
{noformat}

I can find no justification for these changes and technically it broke back compatibility with folks using those action names. I am going to change the action names back to what they were called.



> Rename actions to their prior names in CAS-Crawler
> --------------------------------------------------
>
>                 Key: OODT-727
>                 URL: https://issues.apache.org/jira/browse/OODT-727
>             Project: OODT
>          Issue Type: Bug
>            Reporter: Chris A. Mattmann
>
> OODT-325 and this commit http://svn.apache.org/viewvc?view=revision&revision=1294389 introduced new names to CrawlerActionBeans, such as
> * Renaming UpdateWorkflowStatusToIngest to TriggerPostIngestWorkflow
> * Renaming MoveMetadataToBackupDir to MoveMetadataFileToBackupDir
> * Renaming MoveMetadataToFailureDir to MoveMetadataFileToFailureDir
> You can see all the differences by running this command:
> {noformat}
> curl "http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/action-beans.xml?r1=1294389&r2=1294388&pathrev=1294389&view=patch" | grep id | cut -d\" -f2 | cut -d\+ -f2 | grep -v \ | sort<{noformat}
> Which amount to:
> {noformat}
> CheckMetFileExists
> CheckMetFileExists
> DeleteDataFile
> DeleteDataFile
> DeleteMetadataFile
> DeleteMetadataFile
> DeletePushpullMetFile
> DeletePushpullMetFile
> IngestAncillaryFile
> IngestAncillaryFile
> MoveDataFileToFailureDir
> MoveDataFileToFailureDir
> MoveMetadataFileToBackupDir
> MoveMetadataFileToFailureDir
> MoveMetadataToBackupDir
> MoveMetadataToFailureDir
> MovePushpullMetFileToBackupDir
> MovePushpullMetFileToBackupDir
> MovePushpullMetFileToFailureDir
> MovePushpullMetFileToFailureDir
> SendNotification
> SendNotification
> TriggerPostIngestWorkflow
> Unique
> Unique
> UpdateWorkflowStatusToIngest
> ignoreInvalidAddresses
> ignoreInvalidAddresses
> {noformat}
> I can find no justification for these changes and technically it broke back compatibility with folks using those action names. I am going to change the action names back to what they were called.



--
This message was sent by Atlassian JIRA
(v6.2#6252)