[GitHub] [airflow] ashb commented on a change in pull request #4816: [AIRFLOW-3991] Retrieve configs from commands in environment

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4816: [AIRFLOW-3991] Retrieve configs from commands in environment
URL: https://github.com/apache/airflow/pull/4816#discussion_r296277738
 
 

 ##########
 File path: airflow/configuration.py
 ##########
 @@ -276,6 +274,8 @@ def has_option(self, section, option):
             # UNSET to avoid logging a warning about missing values
             self.get(section, option, fallback=_UNSET)
             return True
+        except NoSectionError:
+            return False
 
 Review comment:
   Do you need to add this change here? If you do please add `[AIRFLOW-4831]` (`[AIRFLOW-3991][AIRFLOW-4831] ...`) in to your commit message and add a test for the changed/improved `has_option` behaviour too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services