[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137827#comment-16137827 ] 

ASF GitHub Bot commented on FLINK-6864:
---------------------------------------

GitHub user zjureel opened a pull request:

    https://github.com/apache/flink/pull/4574

    [FLINK-6864] Fix confusing "invalid POJO type" messages from TypeExtractor

    ## What is the purpose of the change
    
    Fix confusing "invalid POJO type" messages from TypeExtractor
    
    ## Brief change log
    
      - *Improve log about pojo in TypeExtractor*
      - *Add notice in types_serialization.cmd about rules-for-pojo-types*
    
    ## Verifying this change
    
    This change needs no testing
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (yes / no / don't know)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink FLINK-6864

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4574
    
----
commit 5b3861716404c1d1cce9f18af7ca596a21ecb014
Author: zjureel <zj...@gmail.com>
Date:   2017-08-23T02:30:31Z

    [FLINK-6864] Fix confusing "invalid POJO type" messages from TypeExtractor

----


> Remove confusing "invalid POJO type" messages from TypeExtractor
> ----------------------------------------------------------------
>
>                 Key: FLINK-6864
>                 URL: https://issues.apache.org/jira/browse/FLINK-6864
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>
> When a user's type cannot be treated as a POJO, the {{TypeExtractor}} will log warnings such as ".. must have a default constructor to be used as a POJO.", "  ... is not a valid POJO type because not all fields are valid POJO fields." in the {{analyzePojo}} method.
> These messages are often conceived as misleading for the user to think that the job should have failed, whereas in fact in these cases Flink just fallsback to Kryo and treat then as generic types. We should remove these messages, and at the same time improve the type serialization docs at [1] to explicitly inform what it means when Flink does / does not recognizes a user type as a POJO.
> [1] https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/types_serialization.html#rules-for-pojo-types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)