You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by alanconway <gi...@git.apache.org> on 2018/04/09 21:09:51 UTC

[GitHub] qpid-cpp pull request #13: QPID-7926: [c++ broker] Windows build error "cann...

GitHub user alanconway opened a pull request:

    https://github.com/apache/qpid-cpp/pull/13

    QPID-7926: [c++ broker] Windows build error "cannot convert from 'int…

    …' to 'qpid::sys::PODMutex'"
    
    Renamed PODMutex as GlobalMutex. The important point is that it can be used as a
    global variable. In POSIX we use a POD class and static initializer to acomplish
    this, but on windows we use boost::recursive_mutex, which is documented as being
    safe for use as a global variable.
    
    Modified the QPID_MUTEX_INITIALIZER macro to be empty on windows and '= { 0 }'
    on POSIX.
    
    This closes #11

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alanconway/qpid-cpp winfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-cpp/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit e078f320b656fb1b5c79b3a9e490fca23e4d03f7
Author: Justin Ross <jr...@...>
Date:   2018-03-28T13:40:03Z

    QPID-7926: [c++ broker] Windows build error "cannot convert from 'int' to 'qpid::sys::PODMutex'"
    
    Renamed PODMutex as GlobalMutex. The important point is that it can be used as a
    global variable. In POSIX we use a POD class and static initializer to acomplish
    this, but on windows we use boost::recursive_mutex, which is documented as being
    safe for use as a global variable.
    
    Modified the QPID_MUTEX_INITIALIZER macro to be empty on windows and '= { 0 }'
    on POSIX.
    
    This closes #11

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-cpp pull request #13: QPID-7926: [c++ broker] Windows build error "cann...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/qpid-cpp/pull/13


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] qpid-cpp issue #13: QPID-7926: [c++ broker] Windows build error "cannot conv...

Posted by alanconway <gi...@git.apache.org>.
Github user alanconway commented on the issue:

    https://github.com/apache/qpid-cpp/pull/13
  
    This patch cleas up a bit rather than working around the problem like pull #11 (which would also work.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org