[spark] branch branch-3.0 updated: [SPARK-33819][CORE][3.0] SingleFileEventLogFileReader/RollingEventLogFilesFileReader should be `package private`

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new cd683b3  [SPARK-33819][CORE][3.0] SingleFileEventLogFileReader/RollingEventLogFilesFileReader should be `package private`
cd683b3 is described below

commit cd683b330796d3d9eb91278d6cd23f907da2913c
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Thu Dec 17 19:08:04 2020 +0900

    [SPARK-33819][CORE][3.0] SingleFileEventLogFileReader/RollingEventLogFilesFileReader should be `package private`
    
    ### What changes were proposed in this pull request?
    
    This PR aims to convert `EventLogFileReader`'s derived classes into `package private`.
    - SingleFileEventLogFileReader
    - RollingEventLogFilesFileReader
    
    `EventLogFileReader` itself is used in `scheduler` module during tests.
    
    ### Why are the changes needed?
    
    This classes were designed to be internal. This PR hides it explicitly to reduce the maintenance burden.
    
    ### Does this PR introduce _any_ user-facing change?
    
    Yes, but these were exposed accidentally.
    
    ### How was this patch tested?
    
    Pass CIs.
    
    Closes #30820 from dongjoon-hyun/SPARK-33819-3.0.
    
    Authored-by: Dongjoon Hyun <do...@apache.org>
    Signed-off-by: HyukjinKwon <gu...@apache.org>
---
 .../scala/org/apache/spark/deploy/history/EventLogFileReaders.scala   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
index 9f63a64..30ff2c3 100644
--- a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
@@ -164,7 +164,7 @@ object EventLogFileReader {
  * FileNotFoundException could occur if the log file is renamed before getting the
  * status of log file.
  */
-class SingleFileEventLogFileReader(
+private[history] class SingleFileEventLogFileReader(
     fs: FileSystem,
     path: Path) extends EventLogFileReader(fs, path) {
   private lazy val status = fileSystem.getFileStatus(rootPath)
@@ -203,7 +203,7 @@ class SingleFileEventLogFileReader(
  * This reader lists the files only once; if caller would like to play with updated list,
  * it needs to create another reader instance.
  */
-class RollingEventLogFilesFileReader(
+private[history] class RollingEventLogFilesFileReader(
     fs: FileSystem,
     path: Path) extends EventLogFileReader(fs, path) {
   import RollingEventLogFilesWriter._


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org