You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 06:01:34 UTC
[jira] [Created] (SOLR-3343) Move non-shared utils from solrj to
solr core
Move non-shared utils from solrj to solr core
---------------------------------------------
Key: SOLR-3343
URL: https://issues.apache.org/jira/browse/SOLR-3343
Project: Solr
Issue Type: Improvement
Reporter: Chris Male
When doing some unrelated refactoring, I found myself making changes to a class in solrj's {{org.apache.solr.common}} which surprised me. Under closer examination the class was only used inside Solr core and DIH.
I think {{common}} in solrj should only contain those classes which are shared between solrj and other modules. Anything thats not used by solrj should go into solr core (or whatever other module actually makes use of it).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3343) Move non-shared utils from solrj to
solr core
Posted by "Chris Male (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated SOLR-3343:
-----------------------------
Attachment: SOLR-3343.patch
Patch for moving the utils I felt should be moved. Since I used svn 1.6 still, the patch must be executed after the following command:
{noformat}
svn mv solr/solrj/src/java/org/apache/solr/common/util/DOMUtil.java solr/core/src/java/org/apache/solr/util/DOMUtil.java
svn mv solr/solrj/src/java/org/apache/solr/common/util/FastWriter.java solr/core/src/java/org/apache/solr/util/FastWriter.java
svn mv solr/solrj/src/java/org/apache/solr/common/util/FileUtils.java solr/core/src/java/org/apache/solr/util/FileUtils.java
svn mv solr/solrj/src/java/org/apache/solr/common/util/RegexFileFilter.java solr/core/src/java/org/apache/solr/util/RegexFileFilter.java
svn mv solr/solrj/src/java/org/apache/solr/common/util/RTimer.java solr/core/src/java/org/apache/solr/util/RTimer.java
svn mv solr/solrj/src/java/org/apache/solr/common/util/SystemIdResolver.java solr/core/src/java/org/apache/solr/util/SystemIdResolver.java
svn mv solr/solrj/src/test/org/apache/solr/common/util/TestSystemIdResolver.java solr/core/src/test/org/apache/solr/util/TestSystemIdResolver.java
svn mv solr/solrj/src/test/org/apache/solr/common/util/FileUtilsTest.java solr/core/src/test/org/apache/solr/util/FileUtilsTest.java
svn mv solr/solrj/src/test/org/apache/solr/common/util/DOMUtilTest.java solr/core/src/test/org/apache/solr/util/DOMUtilTest.java
{noformat}
I will commit this soon as I want to get onto some other refactoring.
> Move non-shared utils from solrj to solr core
> ---------------------------------------------
>
> Key: SOLR-3343
> URL: https://issues.apache.org/jira/browse/SOLR-3343
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Attachments: SOLR-3343.patch
>
>
> When doing some unrelated refactoring, I found myself making changes to a class in solrj's {{org.apache.solr.common}} which surprised me. Under closer examination the class was only used inside Solr core and DIH.
> I think {{common}} in solrj should only contain those classes which are shared between solrj and other modules. Anything thats not used by solrj should go into solr core (or whatever other module actually makes use of it).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3343) Move non-shared utils from solrj to
solr core
Posted by "Chris Male (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved SOLR-3343.
------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Resolved in trunk.
> Move non-shared utils from solrj to solr core
> ---------------------------------------------
>
> Key: SOLR-3343
> URL: https://issues.apache.org/jira/browse/SOLR-3343
> Project: Solr
> Issue Type: Improvement
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: SOLR-3343.patch
>
>
> When doing some unrelated refactoring, I found myself making changes to a class in solrj's {{org.apache.solr.common}} which surprised me. Under closer examination the class was only used inside Solr core and DIH.
> I think {{common}} in solrj should only contain those classes which are shared between solrj and other modules. Anything thats not used by solrj should go into solr core (or whatever other module actually makes use of it).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org