You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/14 07:18:52 UTC

[GitHub] [iotdb] liuminghui233 opened a new pull request #3565: [IOTDB-1491] UDF query supported in cluster mode

liuminghui233 opened a new pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565


   UDF query supported in cluster mode (no redirect)
   JR: https://issues.apache.org/jira/browse/IOTDB-1491
   
   
   ### TODO:
   1. Redirect version
   2. Add test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41355262/badge)](https://coveralls.io/builds/41355262)
   
   Coverage decreased (-0.01%) to 68.165% when pulling **a413e7bf9759e28b5569ac137198cbe7524e3e2b on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a change in pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#discussion_r669369631



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/query/ClusterQueryRouter.java
##########
@@ -28,21 +28,21 @@
 import org.apache.iotdb.db.exception.StorageEngineException;
 import org.apache.iotdb.db.exception.query.QueryProcessException;
 import org.apache.iotdb.db.metadata.PartialPath;
-import org.apache.iotdb.db.qp.physical.crud.AggregationPlan;
-import org.apache.iotdb.db.qp.physical.crud.GroupByTimePlan;
-import org.apache.iotdb.db.qp.physical.crud.LastQueryPlan;
-import org.apache.iotdb.db.qp.physical.crud.RawDataQueryPlan;
+import org.apache.iotdb.db.qp.physical.crud.*;
 import org.apache.iotdb.db.query.context.QueryContext;
 import org.apache.iotdb.db.query.dataset.groupby.GroupByWithValueFilterDataSet;
 import org.apache.iotdb.db.query.dataset.groupby.GroupByWithoutValueFilterDataSet;
-import org.apache.iotdb.db.query.executor.AggregationExecutor;
-import org.apache.iotdb.db.query.executor.FillQueryExecutor;
-import org.apache.iotdb.db.query.executor.LastQueryExecutor;
-import org.apache.iotdb.db.query.executor.QueryRouter;
-import org.apache.iotdb.db.query.executor.RawDataQueryExecutor;
+import org.apache.iotdb.db.query.executor.*;

Review comment:
       generate, we do not use import *.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41419566/badge)](https://coveralls.io/builds/41419566)
   
   Coverage decreased (-0.01%) to 68.162% when pulling **6900afe7ca5ab8946ee71032474547dc8a31b2ac on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41472460/badge)](https://coveralls.io/builds/41472460)
   
   Coverage decreased (-0.06%) to 68.117% when pulling **8f4753b5500f0ae9a8c784e70bcbd1bee197dd48 on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41472460/badge)](https://coveralls.io/builds/41472460)
   
   Coverage decreased (-0.06%) to 68.117% when pulling **8f4753b5500f0ae9a8c784e70bcbd1bee197dd48 on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41418552/badge)](https://coveralls.io/builds/41418552)
   
   Coverage decreased (-0.03%) to 68.145% when pulling **6900afe7ca5ab8946ee71032474547dc8a31b2ac on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41355349/badge)](https://coveralls.io/builds/41355349)
   
   Coverage decreased (-0.04%) to 68.137% when pulling **a413e7bf9759e28b5569ac137198cbe7524e3e2b on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41418282/badge)](https://coveralls.io/builds/41418282)
   
   Coverage decreased (-0.04%) to 68.138% when pulling **b82096276028db2f1c94c30abd6169de4c49aed9 on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41458751/badge)](https://coveralls.io/builds/41458751)
   
   Coverage decreased (-0.05%) to 68.129% when pulling **2b16e6af14c36b0c39c675419fb6df8c1decf5fc on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on a change in pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on a change in pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#discussion_r669371557



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/query/ClusterQueryRouter.java
##########
@@ -28,21 +28,21 @@
 import org.apache.iotdb.db.exception.StorageEngineException;
 import org.apache.iotdb.db.exception.query.QueryProcessException;
 import org.apache.iotdb.db.metadata.PartialPath;
-import org.apache.iotdb.db.qp.physical.crud.AggregationPlan;
-import org.apache.iotdb.db.qp.physical.crud.GroupByTimePlan;
-import org.apache.iotdb.db.qp.physical.crud.LastQueryPlan;
-import org.apache.iotdb.db.qp.physical.crud.RawDataQueryPlan;
+import org.apache.iotdb.db.qp.physical.crud.*;
 import org.apache.iotdb.db.query.context.QueryContext;
 import org.apache.iotdb.db.query.dataset.groupby.GroupByWithValueFilterDataSet;
 import org.apache.iotdb.db.query.dataset.groupby.GroupByWithoutValueFilterDataSet;
-import org.apache.iotdb.db.query.executor.AggregationExecutor;
-import org.apache.iotdb.db.query.executor.FillQueryExecutor;
-import org.apache.iotdb.db.query.executor.LastQueryExecutor;
-import org.apache.iotdb.db.query.executor.QueryRouter;
-import org.apache.iotdb.db.query.executor.RawDataQueryExecutor;
+import org.apache.iotdb.db.query.executor.*;

Review comment:
       Got it!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41458144/badge)](https://coveralls.io/builds/41458144)
   
   Coverage decreased (-0.03%) to 68.144% when pulling **2b16e6af14c36b0c39c675419fb6df8c1decf5fc on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41396167/badge)](https://coveralls.io/builds/41396167)
   
   Coverage decreased (-0.04%) to 68.133% when pulling **9808834260a0f34d696e54a8a1ec7aca8310920e on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3565: [IOTDB-1491] UDTF query supported in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3565:
URL: https://github.com/apache/iotdb/pull/3565#issuecomment-879694925


   
   [![Coverage Status](https://coveralls.io/builds/41472460/badge)](https://coveralls.io/builds/41472460)
   
   Coverage decreased (-0.06%) to 68.117% when pulling **8f4753b5500f0ae9a8c784e70bcbd1bee197dd48 on liuminghui233:udf_cluster** into **5e020b5880a97c8530b39986b504c5f28fcbcd33 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org