[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2581: IGNITE-20344 Fix rebalance recovery and add tests

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #2581:
URL: https://github.com/apache/ignite-3/pull/2581#discussion_r1324086238


##########
modules/core/src/main/java/org/apache/ignite/internal/streamer/StreamerSubscriber.java:
##########
@@ -223,13 +225,7 @@ private void close(@Nullable Throwable throwable) {
 
             var futs = pendingRequests.values().toArray(new CompletableFuture[0]);
 
-            CompletableFuture.allOf(futs).whenComplete((res, err) -> {
-                if (err != null) {
-                    completionFut.completeExceptionally(err);
-                } else {
-                    completionFut.complete(null);
-                }
-            });
+            CompletableFuture.allOf(futs).whenComplete(copyStateTo(completionFut));

Review Comment:
   This is an unrelated change overall, I don't want to add even more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org