You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/11/07 22:00:03 UTC
Review Request 15326: Added option to reload VM during in
RevertToVMSnapshotCommand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15326/
-----------------------------------------------------------
Review request for cloudstack and edison su.
Repository: cloudstack-git
Description
-------
Added option to reload VM during in RevertToVMSnapshotCommand. For now, only in VMWare as I don't believe that XenServer supports anything similar.
This gives plugins which may have unique snapshot strategies the ability to request the hypervisor to reload the VM's state before attempting to revert to a snapshot.
Diffs
-----
core/src/com/cloud/agent/api/RevertToVMSnapshotCommand.java 1e5fd6c
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 0e2423e
Diff: https://reviews.apache.org/r/15326/diff/
Testing
-------
This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of.
Thanks,
Chris Suich
Re: Review Request 15326: Added option to reload VM during in
RevertToVMSnapshotCommand
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15326/#review28456
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On Nov. 7, 2013, 9 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15326/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 9 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added option to reload VM during in RevertToVMSnapshotCommand. For now, only in VMWare as I don't believe that XenServer supports anything similar.
>
> This gives plugins which may have unique snapshot strategies the ability to request the hypervisor to reload the VM's state before attempting to revert to a snapshot.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/RevertToVMSnapshotCommand.java 1e5fd6c
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 0e2423e
>
> Diff: https://reviews.apache.org/r/15326/diff/
>
>
> Testing
> -------
>
> This has been tested locally with a custom plugin. However, the changes are not used by the existing CloudStack codebase and should not impact any existing workflows or use cases. They are simply for plugins to take advantage of.
>
>
> Thanks,
>
> Chris Suich
>
>