You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/16 16:06:53 UTC

[GitHub] [cordova-lib] raphinesse opened a new pull request #865: test(pkgJson): make expectations work for npm 5 to 7

raphinesse opened a new pull request #865:
URL: https://github.com/apache/cordova-lib/pull/865


   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   In some cases, npm 7 causes the `package.json` to look slightly different than with npm 6. This PR changes our tests so that they work with both flavors.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This PR addresses the following differences:
   
   Saved GitHub URL format in `package.json`:
   - npm 6: `git+https://github.com/apache/cordova-android.git#4.1.x`
   - npm 7: `github:apache/cordova-android#4.1.x`
   
   Empty devDependencies format in `package.json`:
   - npm 6: `{}`
   - npm 7: `undefined`
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Automated tests are passing with both `npm@6` and `npm@^7.2` (with https://github.com/apache/cordova-fetch/pull/91)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-lib] raphinesse merged pull request #865: test(pkgJson): make expectations work for npm 5 to 7

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #865:
URL: https://github.com/apache/cordova-lib/pull/865


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org