[GitHub] [flink] aljoscha commented on a change in pull request #8764: [FLINK-12798][table-planner][table-api-java] Port TableEnvironment to table-api-java module

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #8764:  [FLINK-12798][table-planner][table-api-java] Port TableEnvironment to table-api-java module
URL: https://github.com/apache/flink/pull/8764#discussion_r294673755
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableImpl.java
 ##########
 @@ -0,0 +1,857 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.api.AggregatedTable;
+import org.apache.flink.table.api.FlatAggregateTable;
+import org.apache.flink.table.api.GroupWindow;
+import org.apache.flink.table.api.GroupWindowedTable;
+import org.apache.flink.table.api.GroupedTable;
+import org.apache.flink.table.api.OverWindow;
+import org.apache.flink.table.api.OverWindowedTable;
+import org.apache.flink.table.api.QueryConfig;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.api.WindowGroupedTable;
+import org.apache.flink.table.expressions.Expression;
+import org.apache.flink.table.expressions.ExpressionParser;
+import org.apache.flink.table.expressions.LookupCallResolver;
+import org.apache.flink.table.expressions.catalog.FunctionDefinitionCatalog;
+import org.apache.flink.table.functions.TemporalTableFunction;
+import org.apache.flink.table.functions.TemporalTableFunctionImpl;
+import org.apache.flink.table.operations.JoinQueryOperation.JoinType;
+import org.apache.flink.table.operations.OperationExpressionsUtils;
+import org.apache.flink.table.operations.OperationExpressionsUtils.CategorizedExpressions;
+import org.apache.flink.table.operations.OperationTreeBuilder;
+import org.apache.flink.table.operations.QueryOperation;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation for {@link Table}.
+ */
+@Internal
+public class TableImpl implements Table {
+
+	private static final AtomicInteger uniqueId = new AtomicInteger(0);
+
+	private final TableEnvironment tableEnvironment;
+	private final QueryOperation operationTree;
+	private final OperationTreeBuilder operationTreeBuilder;
+	private final LookupCallResolver callResolver;
+
+	private String tableName = null;
+
+	public TableEnvironment getTableEnvironment() {
+		return tableEnvironment;
+	}
+
+	private TableImpl(
+			TableEnvironment tableEnvironment,
+			QueryOperation operationTree,
+			OperationTreeBuilder operationTreeBuilder,
+			LookupCallResolver callResolver) {
+		this.tableEnvironment = tableEnvironment;
+		this.operationTree = operationTree;
+		this.operationTreeBuilder = operationTreeBuilder;
+		this.callResolver = callResolver;
+	}
+
+	public static TableImpl createTable(
 
 Review comment:
   The reason this is not package private is that `TableEnvImpl.scala` still needs to use this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services