[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #190: [FLINK-27451] Enable the validator plugin in webhook

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #190:
URL: https://github.com/apache/flink-kubernetes-operator/pull/190#discussion_r861669274


##########
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/FlinkOperatorWebhook.java:
##########
@@ -57,8 +59,8 @@ public class FlinkOperatorWebhook {
     public static void main(String[] args) throws Exception {
         EnvUtils.logEnvironmentInfo(LOG, "Flink Kubernetes Webhook", args);
         FlinkConfigManager configManager = new FlinkConfigManager();
-        AdmissionHandler endpoint =
-                new AdmissionHandler(new FlinkValidator(new DefaultValidator(configManager)));
+        Set<FlinkResourceValidator> validators = ValidatorUtils.discoverValidators(configManager);

Review Comment:
   It needs to add `FLINK_PLUGINS_DIR` env variable into `webhook.yaml`, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org