[GitHub] [superset] craig-rueda commented on a change in pull request #12518: ci: remove refs/tags from docker tags on a release

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #12518:
URL: https://github.com/apache/superset/pull/12518#discussion_r557514573



##########
File path: .github/workflows/docker_build_push.sh
##########
@@ -25,7 +25,7 @@ if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
   PR_NUM=$(echo "${GITHUB_REF}" | sed 's:refs/pull/::' | sed 's:/merge::')
   LATEST_TAG="pr-${PR_NUM}"
 elif [[ "${GITHUB_EVENT_NAME}" == "release" ]]; then
-  REFSPEC="${GITHUB_REF}"
+  REFSPEC=$(echo "${GITHUB_REF}" | sed 's:refs/tags/::' | head -c 20)

Review comment:
       Can you change the head to 40? I added 20 kinda arbitrarily. Ive seen several branch names cut off. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org