[jira] [Commented] (PROTON-1197) Ensure that private members don't have exported symbols

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282326#comment-15282326 ] 

ASF subversion and git services commented on PROTON-1197:
---------------------------------------------------------

Commit 772fd54f299251e53b7469df4c415cc5d46d3082 in qpid-proton's branch refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=772fd54 ]

PROTON-1197: [C++ binding] Ensure that symbol export for members is consistent with access
- Usually only public members should have exported symbols.
- This also pointed out a number of completely unused update functions in the *_options
  code that was private.


> Ensure that private members don't have exported symbols
> -------------------------------------------------------
>
>                 Key: PROTON-1197
>                 URL: https://issues.apache.org/jira/browse/PROTON-1197
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> Except if there is a specific reason:
> The only one so far found is if the symbol is used in a template instantiation. This is because this will actually happen when the library client compiles the code as so will need the symbol from the library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org