You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "iprithv (via GitHub)" <gi...@apache.org> on 2026/06/07 16:26:19 UTC

[PR] Fix ControlledRealTimeReopenThread.close() to wake waiters on interrupt [lucene]

iprithv opened a new pull request, #16210:
URL: https://github.com/apache/lucene/pull/16210

   `close()` calls `join()` on the background thread, then bumps `searchingGen` to `Long.MAX_VALUE` and `notifyAll()`s waiters. If `join()` throws `InterruptedException`, the rethrow happened before the bump + notify, so threads in `waitForGeneration(targetGen, -1)` with `targetGen > searchingGen` hung forever.
   
   so moved the cleanup into a `finally` block around `join()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix ControlledRealTimeReopenThread.close() to wake waiters on interrupt [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16210:
URL: https://github.com/apache/lucene/pull/16210#issuecomment-5053085083

   This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix ControlledRealTimeReopenThread.close() to wake waiters on interrupt [lucene]

Posted by "iprithv (via GitHub)" <gi...@apache.org>.
iprithv commented on PR #16210:
URL: https://github.com/apache/lucene/pull/16210#issuecomment-4727799288

   @iverase could you please help review this? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Fix ControlledRealTimeReopenThread.close() to wake waiters on interrupt [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16210:
URL: https://github.com/apache/lucene/pull/16210#issuecomment-6205298548

   This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org