You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xumanbu (via GitHub)" <gi...@apache.org> on 2023/09/12 13:10:23 UTC

[GitHub] [incubator-uniffle] xumanbu opened a new pull request, #1194: [#1192]improvement: add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

xumanbu opened a new pull request, #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194

   …E conf for storing shuffle data
   
   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. Contributor guidelines:
      https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   3. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   add `RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE` with default true : if set false, shuffle data storing in security hdfs use a independent user.
   
   ### Why are the changes needed?
   
   Fix: # (#1192 )
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   add `HadoopSecurityContextTest.testSecuredDisableProxyUser()`  test case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] xumanbu commented on a diff in pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "xumanbu (via GitHub)" <gi...@apache.org>.
xumanbu commented on code in PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#discussion_r1324048804


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -175,6 +175,13 @@ public class RssBaseConf extends RssConf {
           .defaultValue(false)
           .withDescription("Whether enable visiting secured hadoop cluster.");
 
+  public static final ConfigOption<Boolean> RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE =
+      ConfigOptions.key("rss.security.hadoop.kerberos.proxy.user.enable")
+          .booleanType()
+          .defaultValue(true)
+          .withDescription(
+              "Whether create proxy user for spark job user to visiting secured hadoop cluster.");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston commented on pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#issuecomment-1717459985

   lgtm. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston merged pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on code in PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#discussion_r1323942233


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -175,6 +175,13 @@ public class RssBaseConf extends RssConf {
           .defaultValue(false)
           .withDescription("Whether enable visiting secured hadoop cluster.");
 
+  public static final ConfigOption<Boolean> RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE =
+      ConfigOptions.key("rss.security.hadoop.kerberos.proxy.user.enable")
+          .booleanType()
+          .defaultValue(true)
+          .withDescription(
+              "Whether create proxy user for spark job user to visiting secured hadoop cluster.");

Review Comment:
   description: `Whether using proxy user for spark job user to access secured Hadoop cluster`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#issuecomment-1717051055

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1194](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c5b15d7) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/80cc3d1f87798cc4f656fa6ccb8effaf26874748?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (80cc3d1) will **increase** coverage by `0.53%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1194      +/-   ##
   ============================================
   + Coverage     53.64%   54.18%   +0.53%     
   + Complexity     2584     2111     -473     
   ============================================
     Files           391      319      -72     
     Lines         22411    14466    -7945     
     Branches       1875     1314     -561     
   ============================================
   - Hits          12023     7838    -4185     
   + Misses         9682     6209    -3473     
   + Partials        706      419     -287     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/uniffle/common/config/RssBaseConf.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQmFzZUNvbmYuamF2YQ==) | `96.84% <100.00%> (+0.08%)` | :arrow_up: |
   | [...uniffle/common/security/HadoopSecurityContext.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWN1cml0eS9IYWRvb3BTZWN1cml0eUNvbnRleHQuamF2YQ==) | `80.85% <100.00%> (+1.30%)` | :arrow_up: |
   | [...apache/uniffle/common/security/SecurityConfig.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWN1cml0eS9TZWN1cml0eUNvbmZpZy5qYXZh) | `90.00% <100.00%> (+1.76%)` | :arrow_up: |
   | [...niffle/common/security/SecurityContextFactory.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWN1cml0eS9TZWN1cml0eUNvbnRleHRGYWN0b3J5LmphdmE=) | `85.00% <100.00%> (+0.78%)` | :arrow_up: |
   | [.../java/org/apache/uniffle/server/ShuffleServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | `66.26% <100.00%> (-0.95%)` | :arrow_down: |
   
   ... and [75 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1194/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] xumanbu commented on pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "xumanbu (via GitHub)" <gi...@apache.org>.
xumanbu commented on PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#issuecomment-1717042098

   > Could you add a doc if this pr introduce user-facing change?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#discussion_r1324316485


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -175,6 +175,13 @@ public class RssBaseConf extends RssConf {
           .defaultValue(false)
           .withDescription("Whether enable visiting secured hadoop cluster.");
 
+  public static final ConfigOption<Boolean> RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE =
+      ConfigOptions.key("rss.security.hadoop.kerberos.proxy.user.enable")
+          .booleanType()
+          .defaultValue(true)
+          .withDescription(
+              "Whether using proxy user for spark job user to access secured Hadoop cluster.");

Review Comment:
   ```
   spark job -> job
   ```



##########
README.md:
##########
@@ -324,6 +324,7 @@ The following security configurations are introduced.
 |rss.security.hadoop.kerberos.keytab.file|-|The kerberos keytab file path. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid|
 |rss.security.hadoop.kerberos.principal|-|The kerberos keytab principal. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid|
 |rss.security.hadoop.kerberos.relogin.interval.sec|60|The kerberos authentication relogin interval. unit: sec|
+|rss.security.hadoop.kerberos.proxy.user.enable|true|Whether using proxy user for spark job user to access secured Hadoop cluster.|

Review Comment:
   ```
   spark job -> job
   ```
   MR jobs or Tez jobs may use this config option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#discussion_r1324315849


##########
README.md:
##########
@@ -324,6 +324,7 @@ The following security configurations are introduced.
 |rss.security.hadoop.kerberos.keytab.file|-|The kerberos keytab file path. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid|
 |rss.security.hadoop.kerberos.principal|-|The kerberos keytab principal. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid|
 |rss.security.hadoop.kerberos.relogin.interval.sec|60|The kerberos authentication relogin interval. unit: sec|
+|rss.security.hadoop.kerberos.proxy.user.enable|true|Whether using proxy user for spark job user to access secured Hadoop cluster.|

Review Comment:
   ```
   spark job -> jobs
   ```
   MR jobs or Tez jobs may use this config option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] jerqi commented on pull request #1194: [#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1194:
URL: https://github.com/apache/incubator-uniffle/pull/1194#issuecomment-1716807092

   Could you add a doc if this pr introduce user-facing change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org