[GitHub] [ignite] rkondakov commented on a change in pull request #7173: IGNITE-12446: Calcite integration. Fix javadocs and code style.

[GitBox <gi...@apache.org>]

rkondakov commented on a change in pull request #7173: IGNITE-12446: Calcite integration. Fix javadocs and code style.
URL: https://github.com/apache/ignite/pull/7173#discussion_r361322369
 
 

 ##########
 File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/PlannerContext.java
 ##########
 @@ -29,21 +31,43 @@
 import org.apache.ignite.internal.processors.query.calcite.metadata.NodesMapping;
 
 /**
- *
+ * Planner context, encapsulates services, kernal context, query string and its flags and parameters and helper methods
+ * to work with them.
  */
 public final class PlannerContext implements Context {
+    /** */
     private final Context parentContext;
+
+    /** */
     private final Query query;
+
+    /** */
     private final AffinityTopologyVersion topologyVersion;
+
+    /** */
     private final SchemaPlus schema;
+
+    /** */
     private final IgniteLogger logger;
+
+    /** */
     private final GridKernalContext kernalContext;
+
+    /** */
     private final CalciteQueryProcessor queryProcessor;
+
+    /** */
     private final MappingService mappingService;
+
+    /** */
     private final ExchangeProcessor exchangeProcessor;
 
+    /** */
     private IgnitePlanner planner;
 
 Review comment:
   Can it be the final field?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services