You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/11 10:14:34 UTC

[GitHub] [calcite] vlsi commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

vlsi commented on pull request #2323:
URL: https://github.com/apache/calcite/pull/2323#issuecomment-757852039


   Looks good, however, I wonder if it is possible to create a test for such cases.
   Apparently, trying to instantiate every possible rule with a custom "non-logical" rel is a non-starter as it would require lots of code with no gain.
   
   It might be an interesting case for integration testing like "run Hazelcast (or whatever triggers the case) with trunk Calcite". I believe that might be a way more helpful test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org