[GitHub] [tomee] rzo1 commented on pull request #976: [TOMEE-4115] Tomcat update to 9.0.69

[GitBox <gi...@apache.org>]

rzo1 commented on PR #976:
URL: https://github.com/apache/tomee/pull/976#issuecomment-1321112810

   Changelog: https://tomcat.apache.org/tomcat-9.0-doc/changelog.html
   
   ```java
   Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile (default-compile) on project tomee-catalina: Compilation failure
   Error:  /home/runner/work/tomee/tomee/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/LazyStopStandardRoot.java:[38,8] org.apache.tomee.catalina.LazyStopStandardRoot is not abstract and does not override abstract method getArchiveIndexStrategyEnum() in org.apache.catalina.WebResourceRoot
   ```
   
   It seems this update requires some changes due to
   
   >  Add a configuration option to allow bloom filters used to index JAR files to be retained for the lifetime of the web application. Prior to this addition, the indexes were always flushed by the periodic calls to WebResourceRoot.gc(). As part of this addition, configuration of archive indexing moves from Context to WebResourceRoot. Based on a patch provided by Rahul Jaisimha. (markt)
   
   in https://github.com/apache/tomee/blob/tomee-8.x/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/LazyStopStandardRoot.java
   
   It might also need a check, if this change needs some additional changes in that module to fully incorporate it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org