You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:05:23 UTC

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #588: feat: embedding static files into Go binaries

bzp2010 opened a new pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #542 
   
   ### New feature or improvement
   Provides the ability to package static files into Go binaries.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-715654112


   ok then @ShiningRush what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#discussion_r511238043



##########
File path: api/main.go
##########
@@ -14,6 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+//go:generate statik -src=./dashboard -f

Review comment:
       It describes the instructions that will be executed when you run `go generate` directly. Users can use the static command instead of go generate.
   This command does not affect the original compilation process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#discussion_r511238043



##########
File path: api/main.go
##########
@@ -14,6 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+//go:generate statik -src=./dashboard -f

Review comment:
       It describes the instructions that will be executed when you run `go generate` directly. Users can use the static command instead of `go generate`.
   This command does not affect the original compilation process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#discussion_r510665235



##########
File path: api/main.go
##########
@@ -14,6 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+//go:generate statik -src=./dashboard -f

Review comment:
       It means it is optional, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-720569878






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-715653170


   @bzp2010 Could we keep both https://github.com/apache/apisix-dashboard/pull/594 and https://github.com/apache/apisix-dashboard/pull/588?
   
   Two ways to deploy the dashboard:
   - Go with static files
   - Go and static files


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-715653664


   > @bzp2010 Could we keep both #594 and #588?
   > 
   > Two ways to deploy the dashboard:
   > 
   > * Go with static files
   > * Go and static files
   
   Perhaps we can use two compile scripts to implement them separately, or use configuration files to select built-in static files or external folders at Golang runtime.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588#issuecomment-715660795


   this pr is not production ready for those reason:
   - static file path is `/dashboard`
   - it do not contain gin's `no route action` to handle `History Mode`
   - `statik` may be not the best choice for us, we can have a talk before we implement this(more detail plz refer to #594 description).
   
   It is better to embedding files after #594 merged, we can implement this feature base on it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #588: feat: embedding static files into Go binaries

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #588:
URL: https://github.com/apache/apisix-dashboard/pull/588


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org