You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Artemy Tregubenko (JIRA)" <ji...@apache.org> on 2008/08/05 16:58:44 UTC
[jira] Created: (SHINDIG-492) Config option "container_config" is
ignored
Config option "container_config" is ignored
-------------------------------------------
Key: SHINDIG-492
URL: https://issues.apache.org/jira/browse/SHINDIG-492
Project: Shindig
Issue Type: Bug
Components: Gadget Rendering Server (PHP)
Reporter: Artemy Tregubenko
Priority: Minor
Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620189#action_12620189 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
Oh? That's news to me, as far as i am aware (and i'm pretty familiar with the source tree of shindig) there's only a samplecontainer.html file, which works with both the php and java versions of shindig .. and no 'real sns code'.
Both sides have the gadget renderer, proxy, oauth bits and a social-api interface (+ json meta data service, etc), and no SNS code...
What exactly are you referring too? Or do you mean the javascript/samplecontainer code? That really does work with both versions, but i would hardly call that 'SNS code', it's more a simple & static example..
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620205#action_12620205 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
Thats the same features, but the container side (for the rpc service) indeed, if you look at partuza for instance it has:
<script type="text/javascript" src="http://modules.partuza.nl/gadgets/js/rpc.js?c=1"></script>
Which includes the container side JS code for the rpc service ... again that's nothing in the neighbourhood of having a 'SNS', and quite the same between versions though :)
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620182#action_12620182 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
Yeah, I know about common config for java and php, but I'm going to use only php in my project, and wanted to decrease wtf-factor of integration code : )
Thanks for tip about &container=foo!
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620222#action_12620222 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
Okay, no more spam : )
Thanks for your answers : )
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620193#action_12620193 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
FYI here's the html / js based sample container running on the php back-end:
http://shindig-clean.chabotc.com/gadgets/files/samplecontainer/samplecontainer.html
and here's the same code running on the java back-end:
http://www.shindig-demo.org/samplecontainer/samplecontainer.html
Same 'sample container' code, just different gadget renderer and social api code.
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620188#action_12620188 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
Thanks, I already have this url in my bookmarks : )
BTW, I was quite surprised to find that java shindig code has (or at least had some months ago) both sns and gadget rendering parts, while php has only gadget rendering in shindig tree.
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620209#action_12620209 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
But this is static in partuza, and I see no 'feature negotiation' here. This feature is always included, even when it's not needed. Same for tabs and iframe resizing. I had an impression that java creates containers with only required features attached.
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620212#action_12620212 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
Ah well i now understand where the confusion comes from.
The tabs, resizing etc are all gadget side feature libraries, they have no 'container' code.That's why initially i thought you were talking about gadget features.. the /gadgets/rpc?c=1 bit is identical (and 'static') in both versions too, Take a look at any of the sample or live containers, and you'll see that exact same file being included everywhere.
The container only has the 'rpc' code, and the RPC mechanism hooks the gadget calls that require a container page action (such as setting a title, or resizing an iframe) to the container javascript (which isn't included in the features btw, you have to make that your self, see http://code.google.com/p/partuza/source/browse/trunk/html/js/container.js for an container sided example of these functionalities)
The negotiation is done purely on the gadget side, and is initiated by the gadget <Require feature="foo> xml statements, and then the feature dependencies (and the core* features) are added to that set, and a JavaScript blob is generated from that dependency graph.
Both java and php use the same feature libraries, the same physical files, and parse them with exactly the same logic (else there would be some inconsistencies between the two implementations), and their completely identical in what they do and support.
If you want to know exactly how this works i'd suggest taking a look at the following files <shindig/php/>:
./src/gadgets/FeatureSpec.php
./src/gadgets/GadgetFeature.php
./src/gadgets/GadgetFeatureFactory.php
./src/gadgets/GadgetFeatureRegistry.php
./src/gadgets/JsFeatureLoader.php
./src/gadgets/JsLibraryFeatureFactory.php
I'm afraid either you looked at the ning contributed old PHP code (that was removed once we got the 'real' php implementation since it was more a proof of concept then a gadget server implementation), or your confusing the generic feature dep chain resolving with 'container side code', in which case it is still present in both versions.
Anyhow, as i stated a few times before, both implementations are completely identical in their functioning, believe me i know since i wrote all of the php code involved, and the source is there if you want to check how it works... so lets close this long thread before we over-spam the mailing list :)
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620184#action_12620184 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
Ps when your going from the simple 'oww it renders a gadget' example to 'a real sns', there's a few bits you need to be aware of when constructing the iframe url, partuza (a apache licences sample sns) has a decent example of this:
http://code.google.com/p/partuza/source/browse/trunk/Application/Views/gadget/gadget.php
hope that helps!
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620196#action_12620196 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
Ah, that's just the standard <Require feature="foo"> gadget xml feature support, which is present in both the PHP and Java versions of shindig .. which is logical since having 'features' is kind of an essential part of being able to render a gadget and create the javascript for it.
Has nothing to do with SNS or anything though, that's purely gadget stuff & which JS should be injected into it's document
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko closed SHINDIG-492.
-------------------------------------
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620199#action_12620199 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
No-no, I mean that some features require javascript to be injected in both iframe *and* parent document, i.e. because irfame's javascript can't change size of iframe in parent document, as they are on different domains.
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620165#action_12620165 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
Well, I had the idea of keeping my changes to Shindig tree to one folder with local.php and local.js files, however it's not that important.
And by the way, how can I set container=foo to use custom options from new .js file?
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-492.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Ahh right we should indeed remove that configuration key, thanks for the hint.
However you can customize your options quite easily, the system scans the 'container_path' folder for all *.js files, and loads them all in..
The default container.js contains the default configuration (which you shouldn't modify, as you point out it will be updated when you pull down updates from svn).
However if you copy container.js to 'foo.js' and then change :
{"gadgets.container" : ["default"],
to
{"gadgets.container" : ["foo"],
at the top of the file. Or create an empty file that contains:
{"gadgets.container" : ["foo"],
// my-custom-settings-go-here
}
you can make any adjustments there you want too, which will be applied when the container=foo is set.
How it works is that the ContainerConfig class checks the container param + the config key your looking for, and if there is a container specific config setting for it, it uses that one, and otherwise the default value.
This way you can have a lot of different container configurations, and only modify the settings required for those containers... quite a bit more flexible then the original container_config system (which was never really used in practice)
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620178#action_12620178 ]
Chris Chabot commented on SHINDIG-492:
--------------------------------------
The reason for the different locations is that both the java and php versions use the same gadget js space configuration, so that's separate from the php configuration system.
You don't have to 'set' anything, just call the iframe url pointing to the gadget rendered with a &container=foo param appended on it.
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-492) Config option "container_config" is
ignored
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620191#action_12620191 ]
Artemy Tregubenko commented on SHINDIG-492:
-------------------------------------------
Well, I'm not quite sure but when some months ago I had a research of shindig's java, it seemed to me that java code detects which features need specific javascript files on sns-side (like rpc or dynamic height), and includes them when rendering container. Probably I was wrong, or just misled by feature.xml files : )
> Config option "container_config" is ignored
> -------------------------------------------
>
> Key: SHINDIG-492
> URL: https://issues.apache.org/jira/browse/SHINDIG-492
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (PHP)
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
>
> Config file has option "container_config", which allows to use some other config file instead of container.js. However when GadgetContext creates ContainerConfig instance in instanceContainerConfig method, it uses "container_path" option for initialization, thus javascript options are always loaded from /shindig/config/container.js file. This file can be overwritten during shindig update, thus it's not a good idea to customize it, so there's no good way to customize javascript options.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.