[GitHub] [spark] viirya commented on a diff in pull request #37042: [SPARK-39564][SQL][FOLLOWUP] Consider the case of serde available in CatalogTable on explain string for LogicalRelation

[GitBox <gi...@apache.org>]

viirya commented on code in PR #37042:
URL: https://github.com/apache/spark/pull/37042#discussion_r912294587


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -886,7 +886,8 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with Tre
 
   private def stringArgsForCatalogTable(table: CatalogTable): Seq[Any] = {
     table.storage.serde match {
-      case Some(serde) => table.identifier :: serde :: Nil
+      case Some(serde) if SQLConf.get.excludeSerdeOnCatalogTableFromExplain =>

Review Comment:
   ```suggestion
         case Some(serde) if !SQLConf.get.excludeSerdeOnCatalogTableFromExplain =>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org