You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/22 19:26:15 UTC
[GitHub] szha commented on a change in pull request #7799: Add an argument to omit row_sparse_push for end to end benchmarking
szha commented on a change in pull request #7799: Add an argument to omit row_sparse_push for end to end benchmarking
URL: https://github.com/apache/incubator-mxnet/pull/7799#discussion_r140577177
##########
File path: benchmark/python/sparse/sparse_end2end.py
##########
@@ -57,13 +57,15 @@
parser.add_argument('--measure-only', default=None,
help="Measure only",
choices=[IO, COMP, COMM])
+parser.add_argument('--omit-row-sparse-push', action='store_true',
+ help="omit row_sparse_push")
def get_libsvm_data(data_dir, data_name, url, data_origin_name):
if not os.path.isdir(data_dir):
os.system("mkdir " + data_dir)
os.chdir(data_dir)
- if (not os.path.exists(data_name)):
+ if not os.path.exists(data_name):
import urllib
zippath = os.path.join(data_dir, data_origin_name)
urllib.urlretrieve(url, zippath)
Review comment:
Use bz2 instead of relying on the bzip2 command in the os. https://docs.python.org/2/library/bz2.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services