You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "masteryhx (via GitHub)" <gi...@apache.org> on 2023/04/19 10:23:48 UTC

[GitHub] [flink] masteryhx commented on a diff in pull request #21858: [FLINK-30729][state/changelog] Refactor checkState() to WARN of StateChangelogWriter to avoid confusing IllegalException

masteryhx commented on code in PR #21858:
URL: https://github.com/apache/flink/pull/21858#discussion_r1171137916


##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -169,8 +169,11 @@ class FsStateChangelogWriter implements StateChangelogWriter<ChangelogStateHandl
 
     @Override
     public void appendMeta(byte[] value) throws IOException {

Review Comment:
   The method 'append' should also be modified, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org