[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1419: Support specify release candidate number

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185738327


##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
     return version
 
 
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number: Optional[int]) -> None:
     # 0. Write input version to VERSION file
     version = write_version(release_version)
 
     # 1. Git commit and tag
     git = find_command('git', msg='git is required for source packaging')
     run(git, 'commit', '-a', '-m', f'[source-release] prepare release apache-kvrocks-{version}')
-    run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag v{version}')
-
-
+    if release_candidate_number == None:

Review Comment:
   ```suggestion
       if release_candidate_number is None:
   ```
   
   Pythonic and IIRC `==` here can be problematic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org