You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/20 08:53:59 UTC
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8540: [To rel/0.13][IOTDB-5232] Add schema memory metric
SpriCoder commented on code in PR #8540:
URL: https://github.com/apache/iotdb/pull/8540#discussion_r1053055405
##########
server/src/main/java/org/apache/iotdb/db/metadata/MManagerMetrics.java:
##########
@@ -129,6 +150,21 @@ public void unbindFrom(AbstractMetricService metricService) {
"total");
MetricService.getInstance()
- .remove(MetricType.GAUGE, Metric.MEM.toString(), Tag.NAME.toString(), "mtree");
+ .remove(
+ MetricType.GAUGE,
Review Comment:
Please use MetricType.AUTO_GAUGE
##########
server/src/main/java/org/apache/iotdb/db/metadata/MManagerMetrics.java:
##########
@@ -129,6 +150,21 @@ public void unbindFrom(AbstractMetricService metricService) {
"total");
MetricService.getInstance()
- .remove(MetricType.GAUGE, Metric.MEM.toString(), Tag.NAME.toString(), "mtree");
+ .remove(
+ MetricType.GAUGE,
+ Metric.QUANTITY.toString(),
+ Tag.NAME.toString(),
+ "device using template");
+
+ MetricService.getInstance()
+ .remove(
+ MetricType.GAUGE, Metric.MEM.toString(), Tag.NAME.toString(), "schema memory usage");
+
+ MetricService.getInstance()
+ .remove(
+ MetricType.GAUGE,
Review Comment:
Please use MetricType.AUTO_GAUGE
##########
server/src/main/java/org/apache/iotdb/db/metadata/MManagerMetrics.java:
##########
@@ -129,6 +150,21 @@ public void unbindFrom(AbstractMetricService metricService) {
"total");
MetricService.getInstance()
- .remove(MetricType.GAUGE, Metric.MEM.toString(), Tag.NAME.toString(), "mtree");
+ .remove(
+ MetricType.GAUGE,
+ Metric.QUANTITY.toString(),
+ Tag.NAME.toString(),
+ "device using template");
+
+ MetricService.getInstance()
+ .remove(
+ MetricType.GAUGE, Metric.MEM.toString(), Tag.NAME.toString(), "schema memory usage");
Review Comment:
Please use MetricType.AUTO_GAUGE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org