[GitHub] [nifi] ChrisSamo632 commented on pull request #6722: NIFI-10882 prevent setting of both BASIC and API_KEY Authorization Scheme properties in ElasticSearchClientService

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on PR #6722:
URL: https://github.com/apache/nifi/pull/6722#issuecomment-1329679982

   > Thanks for working on this issue @ChrisSamo632! This sounds similar to an issue with ListenSyslog and SSL Context Service, resolved in PR #6441.
   > ...
   
   Yeah, I umm'd and ah'd a bit about which of the approaches to take, then decided I'd opt for replicating what was originally done for NIFI-10760 in #6619 (removed for NIFI-10776 in #6662, but flagged as a non-blocking issue during the 1.19.0 release vote).
   
   Figured raising a PR would cause the discussion to decide which way to go. Another alternative would be for hidden properties to be reset to their default values (at the NiFi Framework level), but that seems like it should be a separate ticket with more considered discussion.
   
   All that said... I've pushed the changes to remove the new `customValidation` and instead base the setting of Auth properties based upon the selected `AUTHORIZATION_SCHEME`, except for `PKI` and `SSLContext` as the latter may be needed even when not using `PKI` for mutual TLS-based IAAA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org