You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/07/21 21:25:18 UTC
[GitHub] [jena] kinow commented on a diff in pull request #1967: Capabilities and locks
kinow commented on code in PR #1967:
URL: https://github.com/apache/jena/pull/1967#discussion_r1271120808
##########
jena-core/src/main/java/org/apache/jena/rdf/model/impl/ModelCom.java:
##########
@@ -1604,9 +1542,8 @@ public GraphListener adapt( final ModelChangedListener L )
{ return new ModelListenerAdapter( this, L ); }
@Override
- public Model notifyEvent( Object e )
- {
- getGraph().getEventManager().notifyEvent( getGraph(), e );
+ public Model notifyEvent(Object e) {
+ getGraph().getEventManager().notifyEvent(getGraph(), e);
return this;
}
-}
+ }
Review Comment:
GH UI shows this as the last line of the file, I think. If it really is, then maybe this space prefix is not needed?
##########
jena-core/src/main/java/org/apache/jena/rdf/model/impl/ModelCom.java:
##########
@@ -1048,32 +1009,26 @@ public int numPrefixes()
{ return getPrefixMapping().numPrefixes() ; }
/**
- Service method to update the namespaces of a Model given the
- mappings from prefix names to sets of URIs.
-
- If the prefix maps to multiple URIs, then we discard it completely.
-
- @param m Model who's namespace is to be updated
- @param ns the namespace map to add to the Model
+ * Service method to update the namespaces of a Model given the mappings from
+ * prefix names to sets of URIs. If the prefix maps to multiple URIs, then we
+ * discard it completely.
+ *
+ * @param m Model who's namespace is to be updated
Review Comment:
s/who's/whose (I think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org