You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2013/02/08 01:11:12 UTC

[jira] [Created] (HBASE-7791) Compaction USER_PRIORITY is broken

Sergey Shelukhin created HBASE-7791:
---------------------------------------

             Summary: Compaction USER_PRIORITY is broken
                 Key: HBASE-7791
                 URL: https://issues.apache.org/jira/browse/HBASE-7791
             Project: HBase
          Issue Type: Bug
            Reporter: Sergey Shelukhin
            Priority: Minor


The code to get compaction priority is as such:
{code}   public int getCompactPriority(int priority) {
     // If this is a user-requested compaction, leave this at the highest priority
     if(priority == Store.PRIORITY_USER) {
       return Store.PRIORITY_USER;
     } else {
       return this.blockingStoreFileCount - this.storefiles.size();
     }
   }
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking stores will override user priority (probably intended); also, if you have blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may cause at least this:
        LOG.debug("Warning, compacting more than " + comConf.getMaxFilesToCompact() +
            " files because of a user-requested major compaction");
as well as some misleading logging.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira