You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2009/04/17 13:23:14 UTC
[jira] Created: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Change org.apache.hadoop.examples.dancing to use new mapreduce api
------------------------------------------------------------------
Key: HADOOP-5694
URL: https://issues.apache.org/jira/browse/HADOOP-5694
Project: Hadoop Core
Issue Type: Sub-task
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Fix Version/s: 0.21.0
Status: Patch Available (was: Open)
test-patch result:
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{noformat}
This example needs to be run on cluster only. Difficult to write unit test for this. Tested the example on cluster. It works fine.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716528#action_12716528 ]
Sharad Agarwal commented on HADOOP-5694:
----------------------------------------
Minor comment on the patch:
The code setting the values of depth, width and height is duplicated. Can we define these say in constant variables ?
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Attachment: patch-5694-1.txt
Patch with review comments incorporated.
test-patch passed on my machine. Tested the patch on cluster.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed])
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Attachment: patch-5694.txt
Attaching correct patch.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717180#action_12717180 ]
Amareshwari Sriramadasu commented on HADOOP-5694:
-------------------------------------------------
Test failures are not related to the patch. All tests passed on my machine.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719585#action_12719585 ]
Hudson commented on HADOOP-5694:
--------------------------------
Integrated in Hadoop-trunk #867 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/867/])
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5694:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Amareshwari!
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Attachment: (was: patch-5938.txt)
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5694:
--------------------------------------------
Attachment: patch-5938.txt
Patch modifying org.apache.hadoop.examples.dancing.DistributedPentomino to use new mapreduce api.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5938.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5694) Change
org.apache.hadoop.examples.dancing to use new mapreduce api
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717092#action_12717092 ]
Hadoop QA commented on HADOOP-5694:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409968/patch-5694-1.txt
against trunk revision 782083.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/478/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/478/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/478/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/478/console
This message is automatically generated.
> Change org.apache.hadoop.examples.dancing to use new mapreduce api
> ------------------------------------------------------------------
>
> Key: HADOOP-5694
> URL: https://issues.apache.org/jira/browse/HADOOP-5694
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5694-1.txt, patch-5694.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.