You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/12/15 22:48:46 UTC
[GitHub] tajo pull request: TAJO-1247: Store type 'TEXTFILE' should be TEXT...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/302
TAJO-1247: Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf
Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/TAJO-1247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit eb7370e3e4ae79104f9a98d890c0f0a3747c7523
Author: clark.kang <cl...@kakao.com>
Date: 2014-12-15T21:35:19Z
TAJO-1247 using text in only sql
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1247: Store type 'TEXTFILE' should be TEXT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1247: Store type 'TEXTFILE' should be TEXT...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/302#issuecomment-67584456
+1
The patch looks nice to me. I'll commit it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---