[GitHub] [jena] afs edited a comment on pull request #1189: JENA-2273: Fix ASK in ResultSetWriterCSV and -TSV

[GitBox <gi...@apache.org>]

afs edited a comment on pull request #1189:
URL: https://github.com/apache/jena/pull/1189#issuecomment-1030884797


   I've pulled PR and it all works, command line and in Fuseki but the build itself fails because of missing Apache License headers on new files.
   
   Sorry for not spotting this earlier.
   
   ```
     jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterCSV.java
     jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TS_ResultSetRIOT_RW.java
     jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterTSV.java
     jena-arq/src/test/java/org/apache/jena/riot/rowset/rw/TestRowSetWriterTSV.java
     jena-arq/src/test/java/org/apache/jena/riot/rowset/rw/TestRowSetWriterCSV.java
     jena-arq/src/test/java/org/apache/jena/riot/rowset/rw/TS_RowSetRIOT_RW.java
   ```
   It is the same header as a file you've modified.
   Touching license headers is something to be done by the contributor, not the project else I'd have fixed them.
   
   I'll leave it up to you whether you want to squash the PR to a single commit or not.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org