Re: [PR] JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle [netbeans]

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #9483:
URL: https://github.com/apache/netbeans/pull/9483#discussion_r3900875749


##########
platform/core.netigso/src/org/netbeans/core/netigso/NetigsoServices.java:
##########
@@ -44,6 +49,33 @@ final class NetigsoServices
         for (ServiceReference ref : f.getRegisteredServices()) {
             MainLookup.register(ref, this);
         }
+        try {
+            // The registration of the felix URLStreamHandler is deactivated in
+            // Netigso.java by setting the felix configuration value of the
+            // property felix.service.urlhandlers to false. That is required
+            // so that the NetBeanss handlers are not replaced/get priority.
+            //
+            // The runtime system however still assumes, that the bundle content
+            // is accessible using the protocols: bundle:, bundleentry: and
+            // bundleresource:.
+            //
+            // Felix does not make the implementing classes directly accessible,
+            // so the implementation is extracted from the Framework
+            // implemenation (org.apache.felix.framework.Felix)
+            Method accessor = f.getClass().getDeclaredMethod("getBundleStreamHandler");
+            accessor.setAccessible(true);
+            URLStreamHandler ush = (URLStreamHandler) accessor.invoke(f);
+            MainLookup.register((URLStreamHandlerFactory) (String protocol) -> {

Review Comment:
   does this become the `delegate` in `ProxyURLStreamHandlerFactory` or simply one of the handlers in its array?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists