You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/26 16:12:41 UTC
[GitHub] [airflow] potiuk opened a new pull request, #33784: Remove "eager upgrade" from PROD image completely
potiuk opened a new pull request, #33784:
URL: https://github.com/apache/airflow/pull/33784
There were still some left-overs of EAGER_UPGRADE in PROD image building. Howwever "eager upgrade" only makes sense for CI images. PROD images when being built should use eager upgrades as they are produced in the CI image step.
This PR does the following:
* removes eager upgrade parameters from PROD image
* replaces it with `--local-constraints` flag that will look for constraints stored in "docker-context-files"
* modifies the CI workflows to upload constraints as artifacts and download them for PROD image build
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33784: Remove "eager upgrade" from PROD image completely
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33784:
URL: https://github.com/apache/airflow/pull/33784#issuecomment-1694490098
This one should help PROD image to not fail (currently observed in 2-7-test branch - `pip` could behave strangely on PROD image build when we build it from source providers - this change should make it to use "current build constraints" as source when "eager upgrade" is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33784: Remove "eager upgrade" from PROD image completely
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33784:
URL: https://github.com/apache/airflow/pull/33784#issuecomment-1694493875
All right. Seems it works. I tested it wiht both - regular case and "upgrade to newer dependencies" - we will need that one to cherry-pick it to 2-7 to make it green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33784: Remove "eager upgrade" from PROD image completely
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33784:
URL: https://github.com/apache/airflow/pull/33784#issuecomment-1694490314
I also added back support for "upgrade to newer dependencies" label that makes it easier to test this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33784: Remove "eager upgrade" from PROD image completely
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33784:
URL: https://github.com/apache/airflow/pull/33784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org