You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by murali-reddy <gi...@git.apache.org> on 2016/11/30 10:52:45 UTC
[GitHub] cloudstack pull request #1801: fix marvin test failure test_router_dhcp_opts
GitHub user murali-reddy opened a pull request:
https://github.com/apache/cloudstack/pull/1801
fix marvin test failure test_router_dhcp_opts
marvin, VirtualMachine objects are not in any particualr order in the array. so
check isdefault attribute to the get non-default nic
earlier test made assumption that nic[0] is default nic, which is not true always
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/murali-reddy/cloudstack test_router_dhcp_opts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1801
----
commit e3912820deeda54942af797dc89bf0dc5e1f53fe
Author: Murali Reddy <mu...@gmail.com>
Date: 2016-11-30T10:49:38Z
fix test failure test_router_dhcp_opts
marvin, VirtualMachine objects are not in any particualr order in the array. so
check isdefault attribute the get non-default nic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
<b>Trillian test result (tid-510)</b>
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33387 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1801-t510-vmware-55u3.zip
Test completed. 39 look ok, 4 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | `Error` | 493.42 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | `Error` | 659.27 | test_vpc_vpn.py
test_06_download_detached_volume | `Error` | 50.51 | test_volumes.py
test_CreateTemplateWithDuplicateName | `Error` | 181.78 | test_templates.py
test_01_create_template | `Error` | 50.77 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 479.44 | test_templates.py
test_04_rvpc_privategw_static_routes | `Error` | 1006.85 | test_privategw_acl.py
test_01_vpc_remote_access_vpn | Success | 197.75 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 456.31 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 715.26 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 574.66 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1570.15 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 617.79 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 597.09 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1210.70 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 31.27 | test_volumes.py
test_05_detach_volume | Success | 110.40 | test_volumes.py
test_04_delete_attached_volume | Success | 15.29 | test_volumes.py
test_03_download_attached_volume | Success | 20.47 | test_volumes.py
test_02_attach_volume | Success | 58.96 | test_volumes.py
test_01_create_volume | Success | 519.95 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.28 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 199.30 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 166.83 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 162.75 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 275.52 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.10 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.17 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 81.93 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.18 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.24 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.30 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.25 | test_vm_life_cycle.py
test_10_destroy_cpvm | Success | 267.85 | test_ssvm.py
test_09_destroy_ssvm | Success | 234.40 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.86 | test_ssvm.py
test_07_reboot_ssvm | Success | 159.37 | test_ssvm.py
test_06_stop_cpvm | Success | 208.05 | test_ssvm.py
test_05_stop_ssvm | Success | 210.82 | test_ssvm.py
test_04_cpvm_internals | Success | 1.93 | test_ssvm.py
test_03_ssvm_internals | Success | 4.78 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.11 | test_ssvm.py
test_01_snapshot_root_disk | Success | 36.47 | test_snapshots.py
test_04_change_offering_small | Success | 87.93 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.09 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.14 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.28 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.28 | test_secondary_storage.py
test_09_reboot_router | Success | 171.81 | test_routers.py
test_08_start_router | Success | 151.60 | test_routers.py
test_07_stop_router | Success | 20.26 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.67 | test_routers.py
test_03_restart_network_cleanup | Success | 181.70 | test_routers.py
test_02_router_internal_adv | Success | 1.08 | test_routers.py
test_01_router_internal_basic | Success | 0.94 | test_routers.py
test_router_dhcphosts | Success | 150.45 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 22.66 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.12 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 30.45 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.33 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.68 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1026.03 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 662.67 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 235.75 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 37.89 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 5.36 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.92 | test_portable_publicip.py
test_isolate_network_password_server | Success | 92.76 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.21 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.55 | test_non_contigiousvlan.py
test_01_nic | Success | 694.49 | test_nic.py
test_releaseIP | Success | 270.17 | test_network.py
test_reboot_router | Success | 703.59 | test_network.py
test_public_ip_user_account | Success | 10.48 | test_network.py
test_public_ip_admin_account | Success | 40.33 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 67.43 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 62.08 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.73 | test_network.py
test_delete_account | Success | 315.66 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.87 | test_network.py
test_01_port_fwd_on_src_nat | Success | 112.35 | test_network.py
test_nic_secondaryip_add_remove | Success | 205.22 | test_multipleips_per_nic.py
login_test_saml_user | Success | 24.98 | test_login.py
test_assign_and_removal_lb | Success | 134.20 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.97 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 188.48 | test_loadbalance.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.28 | test_iso.py
test_03_delete_iso | Success | 95.34 | test_iso.py
test_02_edit_iso | Success | 0.10 | test_iso.py
test_01_create_iso | Success | 21.95 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 572.33 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 451.76 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1159.30 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 934.92 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.64 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.15 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.33 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.12 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.33 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.21 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.36 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 61.69 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 91.32 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 207.08 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.92 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 182.73 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.74 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.95 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 7.67 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 219.52 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 319.28 | test_affinity_groups.py
test_08_resize_volume | Skipped | 5.09 | test_volumes.py
test_07_resize_fail | Skipped | 15.39 | test_volumes.py
test_01_scale_vm | Skipped | 66.30 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1801: fix marvin test failure test_router_dhcp_opts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1801
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@murali-reddy can you use a JIRA id in the git commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1801
I've kicked packaging and will test matrix this pr, LTGM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by murali-reddy <gi...@git.apache.org>.
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1801
test_router_dhcp_opts is passing, and we have necessary LGTM's. can we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack issue #1801: fix marvin test failure
test_router_dhcp_opts
Posted by Sergey Levitskiy <Se...@autodesk.com>.
LGTM
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
LGTM. Thanks @murali-reddy I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1801: fix marvin test failure test_router_dhcp_opts
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---