[GitHub] [iceberg] giucris commented on pull request #7607: Spark: Added Scala/Java IcebergMergeInto Api on spark3.4

["giucris (via GitHub)" <gi...@apache.org>]

giucris commented on PR #7607:
URL: https://github.com/apache/iceberg/pull/7607#issuecomment-1732297343

   Hi @RussellSpitzer and @ConeyLiu. 
   
   First of all, thank you for your time and for your review and excuse me for coming back after a while. I've been a little busy. 
   
   I have been trying to fix all your threads. On others I opened a discussion because I need more clarity on how to proceed. 
   
   Now there is no need to have a Java API since I have included a table method as the main method to start the builder to avoid duplicate code. 
   
   ```scala
   IcebergMergeInto
      .table("icebergTable")
     .using(ds.as("source"))
     .on("source.id == icebergTable.id")
     .whenMatched()
     .updateAll()
     .whenNotMatched()
     .insertAll()
     .merge()
   ```
   
   Let me know what you think, which threads can be closed, which ones to keep ongoing and which ones address into another PR.
   
   Thank you again :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org