[jira] [Commented] (HBASE-16188) Add EventCounter information to log4j properties file

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869345#comment-15869345 ] 

Hadoop QA commented on HBASE-16188:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s {color} | {color:red} HBASE-16188 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12852988/HBASE-16188-1.3.patch |
| JIRA Issue | HBASE-16188 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5728/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Add EventCounter information to log4j properties file
> -----------------------------------------------------
>
>                 Key: HBASE-16188
>                 URL: https://issues.apache.org/jira/browse/HBASE-16188
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.2.1
>            Reporter: Lars George
>            Assignee: Gopi Krishnan Nambiar
>            Priority: Minor
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16188-1.3.patch, HBASE-16188.patch
>
>
> Hadoop's {{JvmMetrics}}, which HBase also is using in Metrics2 and provides it as an MBean, has the ability to count log4j log calls. This is tracked by a special {{Appender}} class, also provided by Hadoop, called {{EventCounter}}. 
> We should add some info how to enable this (or maybe even enable it by default?).
> The appender needs to be added in two places, shown here:
> {noformat}
> hbase.root.logger=INFO,console
> ...
> # Define the root logger to the system property "hbase.root.logger".
> log4j.rootLogger=${hbase.root.logger}, EventCounter
> log4j.appender.EventCounter=org.apache.hadoop.log.metrics.EventCounter
> {noformat}
> We could simply add this commented out akin to the {{hbase-env.sh}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)