You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/08/01 06:46:55 UTC

[GitHub] spark pull request #21936: [SPARK-24981][Core] ShutdownHook timeout causes j...

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21936#discussion_r206769869
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -571,7 +571,12 @@ class SparkContext(config: SparkConf) extends Logging {
         _shutdownHookRef = ShutdownHookManager.addShutdownHook(
           ShutdownHookManager.SPARK_CONTEXT_SHUTDOWN_PRIORITY) { () =>
           logInfo("Invoking stop() from shutdown hook")
    -      stop()
    +      try {
    +        stop()
    +      } catch {
    +        case e: Throwable =>
    +          logWarning("Ignoring Exception while stoping SparkContext. Exception: " + e)
    --- End diff --
    
    `stoping` -> `stopping`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org