[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #192: [ISSUE-186][Feature] Use I/O cost time to select storage paths

[GitBox <gi...@apache.org>]

smallzhongfeng commented on code in PR #192:
URL: https://github.com/apache/incubator-uniffle/pull/192#discussion_r962459717


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorConf.java:
##########
@@ -125,7 +125,21 @@ public class CoordinatorConf extends RssBaseConf {
       .stringType()
       .noDefaultValue()
       .withDescription("Remote Storage Cluster related conf with format $clusterId,$key=$value, separated by ';'");
-
+  public static final ConfigOption<String> COORDINATOR_REMOTE_STORAGE_SELECT_STRATEGY = ConfigOptions
+      .key("rss.coordinator.remote.storage.select.strategy")
+      .stringType()
+      .defaultValue("IO")

Review Comment:
   Of course, you can let users choose by themselves, but I actually prefer the IO strategy, because if you use IO, you can avoid some risks better than the APP strategy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org