You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/06/20 22:12:47 UTC

Review Request: RAVE-579

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5449/
-----------------------------------------------------------

Review request for rave.


Description
-------

Updated alert to fadeIn with a fixed, bottom position. 
A possible improvement to this would be having a fixed top navbar isn't visible or absolute & below nav bar if it is. This however, is far simpler.

https://issues.apache.org/jira/browse/RAVE-579


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1352204 

Diff: https://reviews.apache.org/r/5449/diff/


Testing
-------


Thanks,

Kristen Legacy

Re: Review Request: RAVE-579

Posted by Anthony Carlucci <ac...@mitre.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5449/#review8962
-----------------------------------------------------------

Ship it!


LGTM!

- Anthony Carlucci


On June 20, 2012, 8:12 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5449/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 8:12 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Updated alert to fadeIn with a fixed, bottom position. 
> A possible improvement to this would be having a fixed top navbar isn't visible or absolute & below nav bar if it is. This however, is far simpler.
> 
> https://issues.apache.org/jira/browse/RAVE-579
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1352204 
> 
> Diff: https://reviews.apache.org/r/5449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>