You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/05/28 16:35:27 UTC
[PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
jamesfredley opened a new pull request, #15688:
URL: https://github.com/apache/grails-core/pull/15688
## Step 1 (PR-I, DRAFT): rename `grails.gorm.tests` -> `grails.gorm.specs`
> **Draft / parked.** Opened per @matrei's request to split the `tests` -> `specs` package rename out of the Hibernate 7 Step 1 PR (#15654). Kept as a draft pending project agreement on whether to adopt the rename at all.
### What this does
Renames the legacy `grails.gorm.tests` Spock-spec packages to `grails.gorm.specs` in:
- `grails-data-hibernate5` (90 specs)
- `grails-datamapping-core-test` (18 specs)
Pure package rename - file moves plus `package` / import updates, no behavioural change.
### Scope notes
- The **mongo** portion of this rename is carved separately in PR-E (#15685).
- The **hibernate7** portion stays with the Hibernate 7 work (those modules don't exist on `8.0.x`).
- **neo4j** keeps its own `grails.gorm.tests` packages (each module's specs are independent / module-local).
Assisted-by: claude-code:claude-4.7-opus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4675196222
Closing since we decided to not accept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty closed pull request #15688: Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs
URL: https://github.com/apache/grails-core/pull/15688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4568732014
> This change is IMO not needed to move forward. We can create a low-priority task that suggest the change, and do it when we have a 8.0.0 GA
FYI: in addition to renaming / moving, a lot of tests were broken due to the rename. Several of them have dynamic code that imports these tests. It's actually a lot of work to undo this, but if James F has already done this or is willing I am ok.
What I am saying is it's more convenient to merge it - it's more work to undo it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4571454353
## ✅ All tests passed ✅
🏷️ Commit: 9aff5c0d957a536f992f025f231a414073305634
▶️ Tests: 165 executed
⚪️ Checks: 35/35 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4606155105
## ✅ All tests passed ✅
🏷️ Commit: 96b88bb73073342c3a7a58735f72232b39c00da1
▶️ Tests: 9000 executed
⚪️ Checks: 35/35 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4568546440
This change is IMO not needed to move forward. We can create a low-priority task that suggest the change, and do it when we have a 8.0.0 GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs [grails-core]
Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on PR #15688:
URL: https://github.com/apache/grails-core/pull/15688#issuecomment-4572424233
> FYI: in addition to renaming / moving, a lot of tests were broken due to the rename. Several of them have dynamic code that imports these tests. It's actually a lot of work to undo this, but if James F has already done this or is willing I am ok.
>
> What I am saying is it's more convenient to merge it - it's more work to undo it.
If that's the case, then let's save the work of undoing and spent it on more important issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org