[jira] [Commented] (ROCKETMQ-11) Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801070#comment-15801070 ] 

ASF GitHub Bot commented on ROCKETMQ-11:
----------------------------------------

Github user naughtybear commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/8
  
    @vongosling 
    Hi,
    two places still not align with the pr procedure.
    1. pull request title should be "[ROCKETMQ-11] Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method #8"
    2. commit comment should be "[ROCKETMQ-11] Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method, close apache/incubator-rocketmq#8"
    
    Am I right? If so, I need start a new pull request and modify JIRA info to keep aligned.
    Many thanks.


> Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method
> ----------------------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-11
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-11
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: hanzhaozhan
>            Assignee: vongosling
>            Priority: Trivial
>              Labels: concision
>
> Tiny improvement to make code concise.
> Firstly I thought it's for concurrency consideration. Then I realize it's not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)