You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/05/02 22:21:28 UTC
Re: Review Request 66872: Updated FrameworkInfo comparator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66872/
-----------------------------------------------------------
(Updated May 2, 2018, 6:21 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Changes
-------
Updated Description.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
We now use the MessageDifferencer protobuf utility for a deep/recursive comparison of FrameworkInfo fields. Also removed some existing un-needed comparisons from test cases that were clashing with the new implementation. This is because the previous implementation's limited comparison (just `name` and `user` fields) succeeded whereas it fails with the newer implementaion due to the stricter/fuller nature.
Diffs
-----
include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
Diff: https://reviews.apache.org/r/66872/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66872: Updated FrameworkInfo comparator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66872/#review202527
-----------------------------------------------------------
Per discussion, let's just check all the fields using the existing pattern and figure out how to use MessageDifferencer outside of this chain.
- Benjamin Mahler
On May 2, 2018, 10:21 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66872/
> -----------------------------------------------------------
>
> (Updated May 2, 2018, 10:21 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now use the MessageDifferencer protobuf utility for a deep/recursive
> comparison of FrameworkInfo fields. Also removed some existing un-needed
> comparisons from test cases that were clashing with the new
> implementation. This is because the previous implementation's limited
> comparison (just `name` and `user` fields) succeeded whereas it fails
> with the newer implementaion due to the stricter/fuller nature.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
> include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
> src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
>
>
> Diff: https://reviews.apache.org/r/66872/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66872: Updated FrameworkInfo comparator.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66872/
-----------------------------------------------------------
(Updated May 9, 2018, 9:11 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
The comparator is more strict and checks for all fields. Also removed
some existing un-needed comparisons from test cases that were clashing
with the new implementation. This is because the previous
implementation's limited comparison (just `name` and `user` fields)
succeeded whereas it fails with the newer implementaion due to the
stricter/fuller nature.
Diffs (updated)
-----
include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa
include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb
src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf
Diff: https://reviews.apache.org/r/66872/diff/3/
Changes: https://reviews.apache.org/r/66872/diff/2-3/
Testing
-------
Thanks,
Kapil Arya