You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/12/13 18:00:49 UTC
[GitHub] [phoenix] gokceni commented on a change in pull request #653:
PHOENIX-5618 IndexScrutinyTool fix for array type columns
gokceni commented on a change in pull request #653: PHOENIX-5618 IndexScrutinyTool fix for array type columns
URL: https://github.com/apache/phoenix/pull/653#discussion_r357764055
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
##########
@@ -372,7 +372,16 @@ private boolean compareValues(int startIndex, List<Object> targetValues,
for (int i = startIndex; i < sourceValues.size(); i++) {
Object targetValue = targetValues.get(i);
Object sourceValue = sourceValues.get(i);
- if (targetValue != null && !targetValue.equals(sourceValue)) {
+ if (targetValue != null) {
+ if (sourceValue.getClass().isArray()) {
+ if (compareArrayTypes(sourceValue, targetValue)) {
+ continue;
+ }
+ } else {
+ if (targetValue.equals(sourceValue)) {
Review comment:
I don't think we support nested arrays in Phoenix as a column type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services